Bubble: don't rely on system text styles - #302
Merged
Merged
Conversation
wpkelso
approved these changes
Sep 10, 2026
wpkelso
left a comment
wpkelso
left a comment
Member
There was a problem hiding this comment.
Looks good. Only a semantic question that is realistically better addressed in tandem with Granite and thus not blocking here
|
|
||
| if (notification.priority == URGENT) { | ||
| add_css_class ("urgent"); | ||
| title_label.add_css_class (Granite.CssClass.ERROR); |
Member
There was a problem hiding this comment.
Does "urgent" always imply an error? Even if it's linked to the same styles, should this have a semantic Granite.CssClass.URGENT class added?
Member
Author
There was a problem hiding this comment.
This kind of goes with elementary/granite#1022
Basically, I think urgent should be defined as an emergency which to me is semantically similar to error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on the system stylesheet to handle styles, make sure we add them ourselves here